SQLite integrations #372
Merged
SQLite integrations #372
+1,989
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
requested review from
Copilot and
Alirexaa
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 37 out of 51 changed files in this pull request and generated 1 comment.
Files not reviewed (14)
- CommunityToolkit.Aspire.sln: Language not supported
- Directory.Packages.props: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.Api/CommunityToolkit.Aspire.Sqlite.Api.csproj: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.Api/Migrations/20250107054253_InitialCreate.Designer.cs: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.Api/Properties/launchSettings.json: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.Api/appsettings.json: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.AppHost/CommunityToolkit.Aspire.Sqlite.AppHost.csproj: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.AppHost/Properties/launchSettings.json: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.AppHost/appsettings.json: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.ServiceDefaults/CommunityToolkit.Aspire.Sqlite.ServiceDefaults.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.Sqlite/CommunityToolkit.Aspire.Hosting.Sqlite.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.Sqlite/PublicAPI.Unshipped.txt: Language not supported
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.Api/Migrations/BloggingContextModelSnapshot.cs: Evaluated as low risk
- examples/sqlite/CommunityToolkit.Aspire.Sqlite.Api/Program.cs: Evaluated as low risk
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
aaronpowell
force-pushed
the
aaronpowell/issue364
branch
2 times, most recently
from
b5d214c to
38e8555
Compare
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
Alirexaa
approved these changes
Jan 9, 2025
src/CommunityToolkit.Aspire.Hosting.Sqlite/SqliteResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.Sqlite/SqliteResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Microsoft.Data.Sqlite/AspireSqliteExtensions.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Microsoft.Data.Sqlite/AspireSqliteExtensions.cs
Outdated
Show resolved
Hide resolved
…oid locking issues
Also, finally figured out why db was getting read-only errors, need to set unix file system permissions explicitly%
Also decided to rename the method to AddSqliteConnection to be clearer as to what you're adding
…oid locking issues
Also, finally figured out why db was getting read-only errors, need to set unix file system permissions explicitly%
Also decided to rename the method to AddSqliteConnection to be clearer as to what you're adding
Also decided to rename the method to AddSqliteConnection to be clearer as to what you're adding
…oid locking issues
Also, finally figured out why db was getting read-only errors, need to set unix file system permissions explicitly%
Also decided to rename the method to AddSqliteConnection to be clearer as to what you're adding
aaronpowell
force-pushed
the
aaronpowell/issue364
branch
from
d204efb to
dc59514
Compare
Alirexaa
reviewed
Jan 14, 2025
src/CommunityToolkit.Aspire.Hosting.Sqlite/CommunityToolkit.Aspire.Hosting.Sqlite.csproj
Outdated
Show resolved
Hide resolved
Alirexaa
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
|
@aaronpowell, It would be nice to add new packages to repo README in this RP. |
ah yes, I always forget that. I'll add them soon (digging into the Deno stuff at the moment) |
…pire.Hosting.Sqlite.csproj Co-authored-by: Alireza Baloochi <[email protected]>
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
…olkit/Aspire into aaronpowell/issue364
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a set of integrations for SQLite, across both hosting and client.
The hosting integration will create the SQLite database using a random file name in the user's temp directory, or the path/name provided by the user. It then provides that as a connection string to the client integration. Additionally, the hosting integration can have SQLite Web added to it for a web-based database viewer.
There are two client integrations, one for the "raw" SQLite
DbConnectionimplementation (wrapping Microsoft.Data.Sqlite), and one for Entity Framework Core.Closes #364
PR Checklist
Other information