Dapr azure hosting ext #371

FullStackChef · 2025-01-06T19:36:43Z

Closes #349

Created CommunityToolkit.Aspire.Hosting.Dapr.AzureExtensions
- Provides functionality for referencing azure resources for dapr components
Created CommunityToolkit.Aspire.Hosting.Dapr.AzureRedis
- Provides extensions for referencing azure redis for dapr state

PR Checklist

Other information

Create Dapr Azure Redis project Create Example AppHost + ApiService

Create Dapr resource for provisioning

Use AddAzureInfrastructure

Add AzureDaprComponentResource Start of unit tests

Fixes based on unit tests

davidfowl · 2025-01-08T14:41:23Z

src/CommunityToolkit.Aspire.Hosting.Dapr.AzureRedis/README.md

+2. **`ConfigureRedisStateComponent`**  
+   Internal helper that creates and configures a “state.redis” Dapr component based on the `AzureRedisCacheResource`.  
+   - Generates a valid hostname and port.  
+   - Supports Azure Entra ID (AadEnabled) for secure access.  
+   - Stores or references secrets in Azure Key Vault if password-based authentication is required.


Not sure internal details need to be in the readme

Have adjusted docs

aaronpowell

As I was doing the review, it made me wonder if it wouldn't make more sense to create a single package, CommunityToolkit.Aspire.Hosting.Dapr.Azure.

My understanding is that the AzureExtensions package doesn't really do anything on its own, you'd need to bring in a package such as the Dapr.AzureRedis one or you'd create your own using some other Azure service to act as the caching layer in Azure.

Is the risk that if you aren't wanting to use Azure Redis as the caching layer you're going to end up bringing in some dependencies that are unneeded to the application (and thus "bloat")?

I guess I don't know enough about Dapr and what's needed/how you go about hosting it in Azure to truly understand what alternatives there might need to be in the future.

aaronpowell · 2025-01-08T22:50:44Z

...unityToolkit.Aspire.Hosting.Java.AppHost/CommunityToolkit.Aspire.Hosting.Java.AppHost.csproj

@@ -22,7 +22,6 @@

  <Target Name="PublishRunMaven" AfterTargets="Build">
    <!-- As part of publishing, ensure the Java app is freshly built -->
-    <Exec WorkingDirectory="$(JavaAppRoot)" Command="./mvnw --quiet clean package" />


Can you revert this change, as we have a PR to resolve it (and it'll cause builds to fail if it's not included at the moment)

Done - I'm pretty sure I didn't intentionally remove this.

...tyToolkit.Aspire.Hosting.Dapr.AzureExtensions/ApplicationModel/AzureDaprComponentResource.cs

aaronpowell · 2025-01-08T22:52:58Z

src/CommunityToolkit.Aspire.Hosting.Dapr.AzureExtensions/AzureDaprHostingExtensions.cs

+    public static IResourceBuilder<AzureDaprComponentResource> AddAzureDaprResource(
+        this IResourceBuilder<IDaprComponentResource> builder,
+        [ResourceName] string name,
+        Action<AzureResourceInfrastructure> configureInfrastructure)


This parameter is non-null and thus required, is that intended?

Yes it is intended and required because it is necessary

Is someone always going to need to provide their own configuration callback? Could it not be nullable and we have a default (even if it's just a noop)?

Or is it more that these are methods that you wouldn't realistically use in isolation, you'd only use them through wrappers like the Dapr Azure Redis package?

I mean you could no-op it, but I don't see a use case where you would use it without configuration.

It is primarily designed to be used by the wrappers - and I'm sitting here arguing with myself whether you would realistically use it in isolation.

On one hand if a wrapped integration exists for the component you're wanting to use - it makes sense to use that, however if not this integration avoids the pain I experienced trying to figure it out.

I think provided that I (or someone) can contribute wrapped version in a timely manner then this library could in fact be a supporting library that wasn't published separately?

The more I think about this the more I think that this shouldn't be published on it's own and should only serve as the base for more specific integrations.

src/CommunityToolkit.Aspire.Hosting.Dapr.AzureExtensions/AzureDaprHostingExtensions.cs

tests/CommunityToolkit.Aspire.Hosting.Dapr.AzureRedis.Tests/ResourceCreationTests.cs

…cationModel/AzureDaprComponentResource.cs Co-authored-by: Aaron Powell <[email protected]>

Co-authored-by: Aaron Powell <[email protected]>

…sourceCreationTests.cs Co-authored-by: Aaron Powell <[email protected]>

FullStackChef · 2025-01-09T09:01:28Z

As I was doing the review, it made me wonder if it wouldn't make more sense to create a single package, CommunityToolkit.Aspire.Hosting.Dapr.Azure.

My understanding is that the AzureExtensions package doesn't really do anything on its own, you'd need to bring in a package such as the Dapr.AzureRedis one or you'd create your own using some other Azure service to act as the caching layer in Azure.

Is the risk that if you aren't wanting to use Azure Redis as the caching layer you're going to end up bringing in some dependencies that are unneeded to the application (and thus "bloat")?

I guess I don't know enough about Dapr and what's needed/how you go about hosting it in Azure to truly understand what alternatives there might need to be in the future.

@aaronpowell yeah it would be a pretty bloated integration. Dapr has multiple "building blocks" - state is just one of these building blocks can be used with redis, cosmosdb, postgres, table / blob storage or sql server (to name the azure ones). so you would end up referencing a rather large number of the aspire hosting packages. which felt like it is contra to the design of aspire.

aaronpowell · 2025-01-09T22:54:51Z

src/CommunityToolkit.Aspire.Hosting.Dapr.AzureExtensions/AzureDaprHostingExtensions.cs

+    public static IResourceBuilder<AzureDaprComponentResource> AddAzureDaprResource(
+        this IResourceBuilder<IDaprComponentResource> builder,
+        [ResourceName] string name,
+        Action<AzureResourceInfrastructure> configureInfrastructure)


Is someone always going to need to provide their own configuration callback? Could it not be nullable and we have a default (even if it's just a noop)?

Or is it more that these are methods that you wouldn't realistically use in isolation, you'd only use them through wrappers like the Dapr Azure Redis package?

src/CommunityToolkit.Aspire.Hosting.Dapr.AzureRedis/README.md

aaronpowell · 2025-01-13T01:37:49Z

I'm wondering if the Azure Extensions package should ship as a source-only package (see https://andrewlock.net/creating-source-only-nuget-packages/) so that there's one less binary people would end up with, as they'd compile in the stuff they need (also means things could be marked as internal for library authors).

aaronpowell

I think this looks good - anything else outstanding in your opinion @FullStackChef

FullStackChef added 9 commits January 6, 2025 09:29

Create Dap Azure extensions project

cb357fe

Create Dapr Azure Redis project Create Example AppHost + ApiService

Work in progress

21e200a

Create Dapr resource for provisioning

Remove specific resource as not generating properly

fbe984f

Use AddAzureInfrastructure

Updated to use secret refs

b3ffeca

Fix - Remove code used for testing

035207c

Add AzureDaprComponentResource Start of unit tests

Unit tests +

b499fc4

Fixes based on unit tests

remove bicep file

f95eb10

Tests for AzureRedis

5b8ea45

Add Readme and perform small cleanup tasks

2176a04

WhitWaldo mentioned this pull request Jan 7, 2025

Improve integration between Dapr and Aspire dapr/dotnet-sdk#1428

Open

davidfowl reviewed Jan 8, 2025

View reviewed changes

aaronpowell requested changes Jan 8, 2025

View reviewed changes

FullStackChef and others added 4 commits January 9, 2025 15:19

Update src/CommunityToolkit.Aspire.Hosting.Dapr.AzureExtensions/Appli…

6a2c466

…cationModel/AzureDaprComponentResource.cs Co-authored-by: Aaron Powell <[email protected]>

Apply suggestions from code review

aae735b

Co-authored-by: Aaron Powell <[email protected]>

Revert unintentional change to Java.AppHost

dfa31a0

Update tests/CommunityToolkit.Aspire.Hosting.Dapr.AzureRedis.Tests/Re…

9c8f846

…sourceCreationTests.cs Co-authored-by: Aaron Powell <[email protected]>

FullStackChef added 5 commits January 9, 2025 23:02

Updated azure redis documentation also added missing xmldocs for api

a49de7b

correct unit test approach

57b20fa

remove unnecessary comment

fb2fc3d

null checking

f00affb

More null checking

b74d541

aaronpowell reviewed Jan 9, 2025

View reviewed changes

FullStackChef added 2 commits January 11, 2025 11:23

Update Azure redis readme

8b232a4

Update AzureExtension readme

60b56d0

FullStackChef requested review from aaronpowell and davidfowl January 10, 2025 22:38

Merge branch 'main' into dapr-azure-hosting-ext

2a1d9f0

aaronpowell reviewed Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dapr azure hosting ext #371

Dapr azure hosting ext #371

FullStackChef commented Jan 6, 2025 •

edited

Loading

davidfowl Jan 8, 2025

FullStackChef Jan 9, 2025

aaronpowell left a comment

aaronpowell Jan 8, 2025

FullStackChef Jan 9, 2025

aaronpowell Jan 8, 2025

FullStackChef Jan 9, 2025

aaronpowell Jan 9, 2025

FullStackChef Jan 10, 2025

FullStackChef Jan 10, 2025

FullStackChef commented Jan 9, 2025

aaronpowell Jan 9, 2025

aaronpowell commented Jan 13, 2025

aaronpowell left a comment

Dapr azure hosting ext #371

Are you sure you want to change the base?

Dapr azure hosting ext #371

Conversation

FullStackChef commented Jan 6, 2025 • edited Loading

PR Checklist

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aaronpowell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FullStackChef commented Jan 9, 2025

Choose a reason for hiding this comment

aaronpowell commented Jan 13, 2025

aaronpowell left a comment

Choose a reason for hiding this comment

FullStackChef commented Jan 6, 2025 •

edited

Loading