Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gitflow #11

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Conversation

AkhileshNegi
Copy link
Contributor

@AkhileshNegi AkhileshNegi commented Jan 3, 2021

Changes include:

  • Initial setting up gitflow

Copy link
Member

@Satendra-SR Satendra-SR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkhileshNegi some changes are required, have a look at the comments below.


This document covers some of the important concepts for Gitflow workflow and how to use Gitflow workflow in a project.

### Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a placeholder for macOS as well?
Just add To be added, someone else can go and add it for macOS.


### Installing Gitflow

1. As Git for Windows 2.5.3 and above ships with git-flow (the AVH edition of it), Once git is initialized in the project directory, we can get started with git flow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like I'm reading about Windows 2.5.3. Can we rephrase the sentence a bit?

Suggested change
1. As Git for Windows 2.5.3 and above ships with git-flow (the AVH edition of it), Once git is initialized in the project directory, we can get started with git flow.
1. For Windows, Git with 2.5.3 and above ships with git-flow (the AVH edition of it), so we don't explicitly need to install git-flow. Once git is initialized in the project directory, we can get started with git-flow.


### Windows
1. [Gitflow Installation and Setup Guide](/gitflow/WINDOWS.md)
## Official documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a new heading called Useful Commands and list down all the commands there is a separate file and reference it under this heading?
I saw the documentation has the basic commands but we can add commands like how to create a feature branch using the release branch as the base branch to single time?
Here are some cool examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Satendra-SR We can target this later. I have created an issue #14 for tracking this

@@ -0,0 +1,23 @@
# Gitflow workflow

This document covers some of the important concepts for Gitflow workflow and how to use Gitflow workflow in a project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This document covers some of the important concepts for Gitflow workflow and how to use Gitflow workflow in a project.
This document includes important concepts of **Gitflow Workflow** and how we can start using it in our projects.

@Satendra-SR
Copy link
Member

@AkhileshNegi Please add a PR description before making any further changes and make sure you are not assigning any PR for review before adding a description.

@AkhileshNegi AkhileshNegi merged commit e09ef53 into ColoredCow:master Feb 17, 2021
@AkhileshNegi AkhileshNegi deleted the feature/git-gitflow branch February 17, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants