Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Examples and usecase for Lag windows function #5529

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ultralegendary
Copy link

Description

I have added examples for the lag function and use case for them under windows functions for SQL.
Edited file - content/sql/concepts/window-functions/terms/lag/lag.md
Please review and let me know if any changes required.

Issue Solved

#5395

Type of Change

  • Editing an existing entry (adding examples and single line usecases)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ cigar-galaxy82
✅ PragatiVerma18
✅ Radhika-okhade
❌ Dhivakaran V R


Dhivakaran V R seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ultralegendary
Copy link
Author

hi @cigar-galaxy82 , I have signed the Contributor License Agreement. Please let me know if I have missed anything else.

@cigar-galaxy82 cigar-galaxy82 added enhancement New feature or request sql SQL entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest status: under review Issue or PR is currently being reviewed labels Oct 23, 2024
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some grammatical errors and suggestions for making the content easier to read. Please refer to the comments and make the necessary changes.

Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed the required changes, marking it for second review.

@Radhika-okhade Radhika-okhade self-assigned this Nov 13, 2024
@Radhika-okhade Radhika-okhade added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Nov 13, 2024
made minor grammatical chnages
@Radhika-okhade
Copy link
Collaborator

Hey! @ultralegendary. Could you please sign the CLA so that we can proceed with the second review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest sql SQL entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants