Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4419: [Edit] CSS [Edit] CSS Typography: text-decoration #5527

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Issue 4419: [Edit] CSS [Edit] CSS Typography: text-decoration #5527

wants to merge 7 commits into from

Conversation

ummagohil
Copy link
Contributor

@ummagohil ummagohil commented Oct 18, 2024 •
edited by Sriparno08
Loading

Description

A few changes to the docs to clean up explanations and updated the examples with images.

Issue Solved

Closes #4419

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@ummagohil ummagohil mentioned this pull request Oct 18, 2024
Open
3 tasks
@dakshdeepHERE dakshdeepHERE self-assigned this Oct 23, 2024
@dakshdeepHERE dakshdeepHERE added css CSS entries new entry New entry or entries status: under review Issue or PR is currently being reviewed hacktoberfest hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest and removed hacktoberfest labels Oct 23, 2024
@PragatiVerma18 PragatiVerma18 self-assigned this Nov 15, 2024
dakshdeepHERE
dakshdeepHERE approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the 1st review and this looks good for second review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

Assignees

@PragatiVerma18 PragatiVerma18

@dakshdeepHERE dakshdeepHERE

Labels
css CSS entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest new entry New entry or entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] CSS [Edit] CSS Typography: text-decoration
3 participants
@ummagohil @dakshdeepHERE @PragatiVerma18