Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unescape plus in ALB query string #660

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: unescape plus in ALB query string #660

merged 1 commit into from
Oct 24, 2023

Conversation

johan13
Copy link
Contributor

@johan13 johan13 commented Oct 23, 2023

#219, #552:

Decode + in a query string as a space.

Spaces in a query string are represented with a plus sign, but decodeURIComponent does not decode the plus as a space - it has to be done as a separate step. See also: https://url.spec.whatwg.org/#urlencoded-parsing

Checklist

  • Tests have been added and are passing
  • Documentation has been updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

brettstack
brettstack approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@brettstack brettstack merged commit ebd42d4 into CodeGenieApp:mainline Oct 24, 2023
0 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 14, 2023
@semantic-release-bot
chore(release): 4.10.5 [skip ci]
c1359b0 
## [4.10.5](v4.10.4...v4.10.5) (2023-12-14)

### Bug Fixes

* remove npm audit; remove nodejs14.x; upgrade to nodejs20.x for examples and release ([ee71c9c](ee71c9c))
* unescape plus in ALB query string ([#660](#660)) ([ebd42d4](ebd42d4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettstack brettstack brettstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johan13 @brettstack