Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(criterion): benchmark group generics breaking change #30

Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix(criterion): benchmark group generics breaking change #30

merged 3 commits into from
Nov 20, 2023

Conversation

art049
Copy link
Member

@art049 art049 commented Nov 20, 2023

  • chore: add codspeed badges in sub readmes
  • fix(criterion): add a default measurement to the benchmark group struct
  • feat(criterion): support explicit lifetime for BenchmarkGroup

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 20, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #30 will not alter performance

Comparing fix/benchmark-group-generics (ca39531) with main (6064482)

Summary

✅ 55 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark main fix/benchmark-group-generics Change
🆕 bench_explicit_measurement N/A 0 s N/A
🆕 bench_without_explicit_measurement N/A 0 s N/A

@art049 art049 force-pushed the fix/benchmark-group-generics branch from 95bcb4a to ca39531 Compare November 20, 2023 10:46
@art049 art049 merged commit ca39531 into main Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@art049