feat(criterion): BenchmarkGroup compat with Measurement generic param and plot_config
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aram and `plot_config`
|
By a strange coincidence, I see that @davidhewitt raised a similar issue to the one that this PR addresses, and I happened to meet David at a meet-up in London just a couple of weeks ago. Small world! 😄 |
|
Hey thanks a lot for this. This is awesome. Sorry it took me a bit of time to have a look but it looks perfectly good! |
art049
approved these changes
Nov 14, 2023
CodSpeed Performance ReportMerging #26 will not alter performanceComparing Summary
|
marc2332
added a commit
to marc2332/codspeed-rust
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #25