Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip create_dummy_source when a target uses swift #11845

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Skip create_dummy_source when a target uses swift #11845

wants to merge 2 commits into from

Conversation

CrazyFanFan
Copy link

@CrazyFanFan CrazyFanFan commented Apr 7, 2023 •
edited

Dummy does not need to be created when a Target uses swift.

@CrazyFanFan CrazyFanFan force-pushed the feature/disable_create_dummy_source_when_uses_swift branch from 701c859 to 3ef99d7 Compare April 8, 2023 00:03
@CrazyFanFan
Copy link
Author

My intention was to disable the creation of dummy.m files in a Swift pod, which is one step towards implementing a pure Swift module. However, I tried to modify the test data management approach and didn't quite understand it. As a result, some modules did not generate dummy.m, which was expected. I attempted to modify the test data being used, but ran into some other issues. Is there a document available that provides guidance on modifying tests?

@dnkoutso
Copy link
Contributor

Needs to update integration specs.

@CrazyFanFan CrazyFanFan mentioned this pull request Apr 19, 2023
Open
@CrazyFanFan
Copy link
Author

@dnkoutso thanks for taking a look. Created a PR for the specs update.
CocoaPods/cocoapods-integration-specs#342

@CrazyFanFan CrazyFanFan force-pushed the feature/disable_create_dummy_source_when_uses_swift branch from 14f9cc2 to 3d99cb9 Compare April 19, 2023 17:31
@CrazyFanFan CrazyFanFan force-pushed the feature/disable_create_dummy_source_when_uses_swift branch from 3d99cb9 to d1533b1 Compare August 11, 2023 09:03
@CrazyFanFan
Copy link
Author

@dnkoutso, may I have a review?

@CrazyFanFan CrazyFanFan force-pushed the feature/disable_create_dummy_source_when_uses_swift branch from d1533b1 to 07a6a39 Compare October 12, 2023 07:24
@nikolaykasyanov
Copy link
Contributor

Looks great, this PR would be the first step towards #9649.

@CrazyFanFan
Copy link
Author

Looks great, this PR would be the first step towards #9649.

Another thing is to remove the automatically generated PCH (precompiled header) file by CocoaPods. However, this is a disruptive modification that requires each file to declare its dependencies and import them explicitly. I'm not sure if I really want to do this, but it has dependencies in my other plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CrazyFanFan @dnkoutso @nikolaykasyanov