Fix issue with repo push to empty repo #11653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorde
reviewed
Nov 19, 2022
| @@ -166,7 +166,7 @@ def validate_podspec_files | |||
| # @return [void] | |||
| # | |||
| def check_repo_status | |||
| porcelain_status, = Executable.capture_command('git', %w(status --porcelain), :capture => :merge, :chdir => repo_dir) | |||
| porcelain_status, = Executable.capture_command('git', %w(status --untracked-files=all --porcelain), :capture => :merge, :chdir => repo_dir) | |||
There was a problem hiding this comment.
I don't think we want this change because this would start failing for any spec repo that has untracked files in it, which would not happen today
amorde
reviewed
Nov 19, 2022
| @@ -231,7 +231,7 @@ def add_specs_to_repo | |||
| end | |||
|
|
|||
| # only commit if modified | |||
| if repo_git('status', '--porcelain').include?(spec.name) | |||
| if repo_git('status', '--untracked-files=all', '--porcelain').include?(spec.name) | |||
There was a problem hiding this comment.
perhaps we should pass in spec.name to the git status invocation so we only check that single file, rather than potentially looking at a large amount of untracked files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to create private repository
After execution of:
pod repo push TEST <SPEC_NAME>.podspec --allow-warnings --use-jsonI have a message then nothing changed
/usr/bin/git -C <PATH>/Specs status --porcelain?? Specs/2/- [No change] CAClient-debug (1.0.0)so only after adding
--untracked-files=allor-uallgit status --untracked-files=all --porcelaingit status retruns full path of untracked changes
?? Specs/2/0/a/<POD_NAME>/1.0.0/<POD_NAME>.podspec.jsonthis fix could solve the problem with untracked files which was added