Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an external pod that downloaded the wrong content #11544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xuzhongping
Copy link
Contributor

Issue

Description

How to appear

  1. Introduce a PodA in the Podfile: pod 'A', :git => 'ARepo';
  2. In ARepo, source = 'BRepo' in the A.podspec file, and file_patterns will not match any files

This causes an empty folder A to be created in the sandbox after the first pod install, but on the second pod install, the contents of BRepo will appear in folder A in the sandbox.
It is very puzzling that no changes were made between the two pod installs, but two different results are produced.

Reason

In the second pod install, because in the process of processing the external pod, only the existence of the folder is judged, but not whether there is no content, so it is considered that it does not belong to the pre-download; in the later dependency download process it is judged as the sandbox state of the release pod, and the contents of the podspec are used to re-download, which leads to the different results of the two installs.

@xuzhongping
Copy link
Contributor Author

Sorry,there were some errors and I would look for exceptions in the commit code.

@xuzhongping
Copy link
Contributor Author

@dnkoutso @amorde @orta Hi, can you review this PR? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant