Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change designated initializer on DDOSLogger #1417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ffried
Copy link
Member

@ffried ffried commented Apr 16, 2024

New Pull Request Checklist


  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass
  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: -

Pull Request Description

With #1410, the designated initializer of DDOSLogger should have been changed, but couldn't since it would be a breaking change. After the version now being bumped to 3.9.0, this PR updates the designated initializer of DDOSLogger.

Copy link

github-actions bot commented Apr 16, 2024

Warnings
⚠️ Any changes to library code should be reflected in the CHANGELOG. Please consider adding a note there about your change.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against e8954e6

@ffried ffried force-pushed the feature/oslogger-designated-initializer branch from 6722477 to 4e98a71 Compare April 16, 2024 14:35
@ffried ffried force-pushed the feature/oslogger-designated-initializer branch from 4e98a71 to e8954e6 Compare April 16, 2024 15:43
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.10%. Comparing base (dc28b52) to head (e8954e6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   54.30%   52.10%   -2.21%     
==========================================
  Files          32       32              
  Lines        4587     4564      -23     
  Branches      515      514       -1     
==========================================
- Hits         2491     2378     -113     
- Misses       2096     2186      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant