Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: command: do_help does not work as a 3rd level subcommand #1560

Merged

Conversation

nicholasyang2022
Copy link
Collaborator

should pass the name of all ancestor levels to help_contextual.

should pass the name of all ancestor levels to `help_contextual`.
@nicholasyang2022 nicholasyang2022 changed the title Fix: command: do_help does not as as a 3rd level subcommand Fix: command: do_help does not work as a 3rd level subcommand Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (c4ce88e) to head (541da04).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 55.20% <100.00%> (-0.01%) ⬇️
unit 52.72% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/command.py 62.36% <100.00%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review September 23, 2024 07:32
@liangxin1300 liangxin1300 merged commit ca41b17 into ClusterLabs:master Sep 24, 2024
32 checks passed
@nicholasyang2022 nicholasyang2022 deleted the fix-do-help-multilevel branch September 30, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants