Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: run-functional-tests: "-n" option can grow more nodes #1235

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zzhou1
Copy link
Contributor

@zzhou1 zzhou1 commented Aug 18, 2023

  1. Support podman 5.x network inspect in TW environment

  2. Improve -n option to grow more cluster nodes or bare nodes

To grow more cluster nodes with a bigger number than '2' in the above example
# crmsh.git/test/run-functional-tests -n 5

To grow more bare nodes
# crmsh.git/test/run-functional-tests -n 7 -x
  1. "-S" option skips the cluster start right after the node creation
To create 40 nodes with corosync.conf without start the cluster
# crmsh.git/test/run-functional-tests -n 32 -S

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.25%. Comparing base (9b1d80f) to head (015c54a).

Additional details and impacted files
Flag Coverage Δ
integration 54.49% <ø> (-0.01%) ⬇️
unit 52.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zzhou1 zzhou1 force-pushed the 202308_run-functional-tests_can_grow_nodes branch from 042c074 to 14bfe4a Compare September 3, 2023 14:44
@zzhou1 zzhou1 changed the title Dev: run-functional-tests: "-n" or "-n X..Y" can grow more nodes Dev: run-functional-tests: "-n" option can grow more nodes Sep 3, 2023
Copy link
Collaborator

@liangxin1300 liangxin1300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Thanks

@liangxin1300
Copy link
Collaborator

@zzhou1
There was one issue I found

./test/run-functional-tests -n 2 
./test/run-functional-tests -n 4

Then created two 2-node clusters, not one 4-node cluster

@zzhou1 zzhou1 force-pushed the 202308_run-functional-tests_can_grow_nodes branch from 14bfe4a to ec6f7ae Compare November 21, 2024 06:58
@zzhou1 zzhou1 marked this pull request as draft November 21, 2024 07:02
@zzhou1 zzhou1 force-pushed the 202308_run-functional-tests_can_grow_nodes branch 3 times, most recently from 58bf740 to c1d4595 Compare November 22, 2024 05:31
@zzhou1 zzhou1 force-pushed the 202308_run-functional-tests_can_grow_nodes branch from c1d4595 to 015c54a Compare November 25, 2024 06:28
@zzhou1 zzhou1 marked this pull request as ready for review November 25, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants