Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS support #312

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

GPS support #312

wants to merge 25 commits into from

Conversation

BrentonPoke
Copy link
Contributor

@BrentonPoke BrentonPoke commented Jul 9, 2023

Describe at a high level the solution you're providing
Supporting GPS in-house through TinyGPS++ with an intuitive API.

Is this a patch, a minor version change, or a major version change
minor.

Is this related to an open issue?
#311

Additional context
WIP right now

@BrentonPoke BrentonPoke changed the title GPS support WIP GPS support Jul 17, 2023
@tqrahman tqrahman self-assigned this Jul 17, 2023
@BrentonPoke
Copy link
Contributor Author

Decided to bring the printData() helper function internal and use the DuckLogger interface since there seemed to be some confusion about its purpose. It was originally intended for the developer to use at will without having to use debug flags. It now uses the debug log level and people will just have to enable debugging for everything if they want to see the printout.

Signed-off-by: Brenton Poke <[email protected]>
@BrentonPoke
Copy link
Contributor Author

#if defined(CDPCFG_GPS_RX) && defined(CDPCFG_GPS_TX)
#include <DuckGPS.h>
#endif

This is how the preprocessor guards are going to be used in cdpcfdg.h after the board definition section. It'll look for the receive and transmit pin definitions to determine whether to auto-include GPS stuff. I also added a preprocessor guard on one of the initializers that take from the board config. This way people can still use the DuckGPS API if they define the pins themselves.

…t is also true for ArduinoIDE. This change should ensure nothing breaks while allowing platformio to work properly.

Signed-off-by: Brenton Poke <[email protected]>
Signed-off-by: Brenton Poke <[email protected]>
Signed-off-by: Brenton Poke <[email protected]>
Signed-off-by: Brenton Poke <[email protected]>
@krook krook changed the title GPS support WIP: GPS support Mar 8, 2024
@BrentonPoke BrentonPoke changed the title WIP: GPS support GPS support Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants