WIP: Show object detail on click #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to remove react-mapbox-gl dep, since our
use case is simple (just lots of layer declarations)
and the dependency adds complexity and larger bundles.
String geojson feature IDs don't get copied into the
vector tiles, thus can't be used for "feature state":
mapbox/mapbox-gl-js#2716
Work around just uses osm object id via "promoteId".
It's possible but unlikely that two objects of different
types could share the same int id in a single diff. I
think the behavior in this case is just that both
elements with the same id would receive the same hover state.
The duplicate is likely offscreen.
Add prettierrc to set max width to 100
TODO: Verify find logic for old/new versions of object in map click handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds pointer and highlights on feature hover.
TODO:
Notes
Ran
npm audit fix.Removes react-mapbox-gl. I rewrote the map component to help debug an issue and it ended up being a relatively straightforward implementation that made including the extra lib not seem worth it.