-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: service copy without default template #1558
Merged
0utplay
merged 5 commits into
nightly
from
fix/GH-1550-service-copy-without-default-template
Dec 20, 2024
Merged
fix: service copy without default template #1558
0utplay
merged 5 commits into
nightly
from
fix/GH-1550-service-copy-without-default-template
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
in: node
An issue/pull request releated to the node module code
t: fix
A pull request introducing a fix for a bug.
labels
Dec 16, 2024
Test Results 48 files ±0 48 suites ±0 1m 40s ⏱️ -1s Results for commit 119bb58. ± Comparison against base commit 71fa7ca. This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Dec 20, 2024
0utplay
deleted the
fix/GH-1550-service-copy-without-default-template
branch
December 20, 2024 19:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When copying a service without providing a template we try to fallback to the "/default" template. But our fallback logic is not working correctly and causing an NPE.
Modification
We now only accept a single service when copying. If no default template exists and no template is provided we respond with an message indicating the missing template.
Result
The
service <Service> copy
Command is working again.Other context
Fixes #1550