Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add npc info command #1485

Open
wants to merge 2 commits into
base: nightly
Choose a base branch
from
Open

feat: add npc info command #1485

wants to merge 2 commits into from

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Aug 18, 2024

Motivation

NPCs do not really have an option to display all set options.

Modification

Added a new command (/cn info) which prints all information about a npc.

Result

NPC information are available (especially for support)

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: improvement The pull request improves existing code in: module An issue/pull request releated to one of the internal modules labels Aug 18, 2024
@0utplay 0utplay added this to the 4.0.0-RC11 milestone Aug 18, 2024
@0utplay 0utplay requested a review from derklaro August 18, 2024 19:52
@0utplay 0utplay self-assigned this Aug 18, 2024
Copy link

github-actions bot commented Aug 18, 2024

Test Results

 48 files  ±0   48 suites  ±0   2m 4s ⏱️ -8s
420 tests ±0  420 ✅ ±0  0 💤 ±0  0 ❌ ±0 
751 runs  ±0  751 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1155e6e. ± Comparison against base commit c37bd68.

This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","this":"is","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-08-18
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 16:05:05.295014907
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 16:05:05.295073568Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 16:05:05.295095379Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 16:05:05.295103965+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 16:05:05.295121077-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-08-18T16:05:05.295157787
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-08-18T16:05:05.295210827Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-08-18T16:05:05.294784352Z
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-09-09
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 11:20:11.580991467
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 11:20:11.581063042Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 11:20:11.581091596Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 11:20:11.581104219+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 11:20:11.581124949-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-09-09T11:20:11.581171777
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-09-09T11:20:11.581248421Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-09-09T11:20:11.580738502Z
…

♻️ This comment has been updated with latest results.

@0utplay 0utplay requested a review from derklaro September 9, 2024 11:17
@derklaro derklaro modified the milestones: 4.0.0-RC11, 4.0.0-RC12 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: module An issue/pull request releated to one of the internal modules t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants