-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add npc info command #1485
Open
0utplay
wants to merge
2
commits into
nightly
Choose a base branch
from
npc-info-command
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
t: improvement
The pull request improves existing code
in: module
An issue/pull request releated to one of the internal modules
labels
Aug 18, 2024
Test Results 48 files ±0 48 suites ±0 2m 4s ⏱️ -8s Results for commit 1155e6e. ± Comparison against base commit c37bd68. This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
derklaro
reviewed
Sep 9, 2024
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Outdated
Show resolved
Hide resolved
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: module
An issue/pull request releated to one of the internal modules
t: improvement
The pull request improves existing code
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NPCs do not really have an option to display all set options.
Modification
Added a new command (/cn info) which prints all information about a npc.
Result
NPC information are available (especially for support)