Fix to full-text search, property typo #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search wasn't working, file contents weren't being indexed (content properties were empty), simple typo "item.content" needs to be "item.content_markdown". Fix gets file contents into index and I get expected search results in generated site. There may be further tweaks needed in filtering the content (for example, markdown table pipes and dashes should be filtered out), but this well enough for now.
Use item.content_markdown instead of item.content
The search/index.html results page as built assumes the root for the sidebar nav links. When you set a baseurl for your project, the sidebar nav links break. Added site.baseurl to link resolution.
Sidebar nav from search results broken when using baseurl
Revert "Sidebar nav from search results broken when using baseurl"
The search/index.html results page as built assumes the root for the sidebar nav links. When you set a baseurl for your project, the sidebar nav links break. Added site.baseurl to link resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From commit: Search wasn't working, file contents weren't being indexed (content properties were empty), simple typo "item.content" needs to be "item.content_markdown". Fix gets file contents into index and I get expected search results in generated site. There may be further tweaks needed in filtering the content (for example, markdown table pipes and dashes should be filtered out), but this well enough for now.