✨ Reset popup auto-close timer on interaction with popup #1071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I noticed that the timer for auto-close does not reset on interaction with the popup, which sometimes causes the popup to close prematurely when I'm about to click a button. Looking at the code, it looks like this was meant to be implemented with
context.resetCloseTimeout
but this did not work.This PR adds that functionality (including for
click
alongsidetouchstart
so that this works on desktop devices), such that any interaction within the popup will reset the timer to it's configured valueType of change
Additional information
To test the change:
Additional documentation needed.
N/A
Checklist
If user exposed functionality or configuration variables are added/changed: