Media player styles fixes + Box shadow var fixes

- [x] The box shadow variable was changing the cover buttons instead of the card with the large layout, this is now fixed #1039 - [x] Fixed the border radius for the media player card normal layout #1034 - [x] Fixed the « undefined » message that was spamming the browser console
Clooos · Dec 13, 2024 · 9a76cdb · 9a76cdb
1 parent 6b64d53
commit 9a76cdb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/dist/bubble-card.js b/dist/bubble-card.js
diff --git a/src/cards/cover/styles.ts b/src/cards/cover/styles.ts
@@ -102,6 +102,7 @@ export default `
       display: flex;
       background: var(--bubble-cover-main-background-color, var(--bubble-main-background-color, var(--background-color-2, var(--secondary-background-color))));
       border-radius: var(--bubble-cover-border-radius, var(--bubble-border-radius, 32px));
+      box-shadow: var(--bubble-cover-box-shadow, var(--bubble-button-box-shadow, var(--bubble-box-shadow, none)));
     }
 
     .large .bubble-buttons .bubble-icon {
@@ -138,6 +139,11 @@ export default `
       grid-gap: 18px;
     }
 
+    .large .bubble-button,
+    .large .bubble-sub-button {
+      box-shadow: none;
+    }
+
     .large .bubble-sub-button-container {
       margin-right: 14px;
     }

diff --git a/src/cards/media-player/styles.ts b/src/cards/media-player/styles.ts
@@ -19,7 +19,7 @@ export default `
         height: 50px;
         background-color: var(--bubble-media-player-main-background-color, var(--bubble-main-background-color, var(--background-color-2, var(--secondary-background-color))));
         touch-action: pan-y;
-        var(--bubble-media-player-border-radius, var(--bubble-border-radius, 32px));
+        border-radius: var(--bubble-media-player-border-radius, var(--bubble-border-radius, 32px));
         box-shadow: var(--bubble-media-player-box-shadow, var(--bubble-box-shadow, none));
     }
 

diff --git a/src/cards/pop-up/changes.ts b/src/cards/pop-up/changes.ts
@@ -118,8 +118,6 @@ export function changeTriggered(context) {
         const isInitialLoad = !context.hasPageLoaded;
         context.hasPageLoaded = true;
 
-        console.log(context.hashAdded)
-
         //Check conditions
         const triggerConditions_array = ensureArray(triggerConditions);
         if (validateConditionalConfig(triggerConditions_array)){

diff --git a/src/var/version.ts b/src/var/version.ts
@@ -1 +1 @@
-export let version = 'v2.3.2';
+export let version = 'v2.3.3';
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export let version = 'v2.3.2';
		export let version = 'v2.3.3';