Remove usage of std::regex

include/rocksdb/utilities/object_registry.h

@@ -72,20 +72,23 @@ class ObjectLibrary {
         : Entry(name), factory_(std::move(f)) {
       // FIXME: the API needs to expose this failure mode. For now, bad regexes
       // will match nothing.
-      Regex::Parse(name, &regex_).PermitUncheckedError();
+      /// Regex::Parse(name, &regex_).PermitUncheckedError();
     }
     ~FactoryEntry() override {}
-    bool matches(const std::string& target) const override {
-      return regex_.Matches(target);
-    }
+    /// No more std::regex, see https://github.com/ClickHouse/llvm-project/pull/38
+    /// Luckily, nobody calls this function. If this is no longer the case, please link rocksdb
+    /// to RE2 and use re2::FullMatch() instead of regex_match().
+    /// bool matches(const std::string& target) const override {
+    ///   return regex_.Matches(target);
+    /// }
     // Creates a new T object.
     T* NewFactoryObject(const std::string& target, std::unique_ptr<T>* guard,
                         std::string* msg) const {
       return factory_(target, guard, msg);
     }
 
    private:
-    Regex regex_;  // The pattern for this entry
+    /// Regex regex_;  // The pattern for this entry
     FactoryFunc<T> factory_;
   };  // End class FactoryEntry
  public:

include/rocksdb/utilities/regex.h

@@ -12,6 +12,8 @@
 
 #include "rocksdb/status.h"
 
+#if 0 /// ClickHouse-specific patch: disallow std::regexp
+
 namespace ROCKSDB_NAMESPACE {
 
 // A wrapper for parsed regular expressions. The regex syntax and matching is
@@ -45,4 +47,6 @@ class Regex {
 };
 }  // namespace ROCKSDB_NAMESPACE
 
+#endif // 0
+
 #endif  // ROCKSDB_LITE

util/regex.cc

@@ -8,6 +8,8 @@
 
 #include "rocksdb/utilities/regex.h"
 
+#if 0 /// ClickHouse-specific patch: disallow std::regexp
+
 #include <cassert>
 #include <regex>
 
@@ -47,4 +49,6 @@ Status Regex::Parse(const char *pattern, Regex *out) {
 
 }  // namespace ROCKSDB_NAMESPACE
 
+#endif // 0
+
 #endif  // ROCKSDB_LITE