Add Insert::written_bytes method
#191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loyd
requested changes
Dec 16, 2024
|
|
||
| /// Returns the number of serialized bytes that have been written because of | ||
| /// write operations. | ||
| pub fn written_bytes(&self) -> usize { |
There was a problem hiding this comment.
Add #[inline], please, it's supposed to be called on every row, so it's reasonable to allow over-crate inlining.
Also, please run benchmarks (the insert bench with `--features inserter) to ensure we don't introduce regression here. Run on master and this branch and share results.
|
LGTM, thanks for your contribution! @mmcgee-jump, can you share why the |
loyd
requested changes
Dec 16, 2024
|
|
||
| /// Returns the number of serialized bytes that have been written because of | ||
| /// write operations. | ||
| pub fn written_bytes(&self) -> usize { |
There was a problem hiding this comment.
Also, it's questionable to use usize vs u64 here.
Formally, it's possible to write more than 4GiB on 32b systems inside one INSERT query.
So, I think we should use u64 here.
loyd
changed the title
Insert::written_bytes method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a function to retrieve
written_bytesfrom andInsert, so users can create their own inserter logic.