Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cursor): return NotEnoughData #186

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(cursor): return NotEnoughData #186

merged 1 commit into from
Dec 10, 2024

Conversation

loyd
Copy link
Collaborator

@loyd loyd commented Dec 8, 2024

Summary

It fixes the regression introduced in #169.
Previously, the cursor checked if unhandled bytes were left.
Return this behavior to detect schema mismatch.

Closes #185

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided so that we can include it in CHANGELOG later
  • For significant changes, documentation in README and https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@loyd loyd requested a review from slvrtrn December 8, 2024 12:39
It fixes the regression introduced in #169.
Previously, the cursor checked if unhandled bytes were left.
Return this behaviour to detect schema mismatch.

Closes #185
@loyd loyd force-pushed the fix/185-not-enough-data branch from 789e9a2 to 955e819 Compare December 8, 2024 12:42
src/cursor.rs Show resolved Hide resolved
@slvrtrn slvrtrn merged commit 2803c8e into main Dec 10, 2024
6 checks passed
@loyd loyd deleted the fix/185-not-enough-data branch December 15, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

throw an error instead of returning empty if client fails to deserialize query results
2 participants