fix SQL_DESC_OCTET_LENGTH

ClickHouse · Sep 1, 2017 · d0fdb8a · d0fdb8a
1 parent 295f92d
commit d0fdb8a
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/driver/environment.h b/driver/environment.h
@@ -21,6 +21,11 @@ struct TypeInfo
             sql_type == SQL_TINYINT || sql_type == SQL_SMALLINT ||
             sql_type == SQL_INTEGER || sql_type == SQL_BIGINT;
     }
+
+    inline bool IsStringType() const
+    {
+        return sql_type == SQL_VARCHAR;
+    }
 };
 
 

diff --git a/driver/odbc.cpp b/driver/odbc.cpp
@@ -236,9 +236,12 @@ SQLColAttribute(HSTMT statement_handle, SQLUSMALLINT column_number, SQLUSMALLINT
                 num_value = column_info.is_nullable;
                 break;
             case SQL_DESC_OCTET_LENGTH:
-                if (column_info.fixed_size)
+                if (type_info.IsStringType())
                 {
-                    num_value = column_info.fixed_size;
+                    if (column_info.fixed_size)
+                        num_value = column_info.fixed_size * SIZEOF_CHAR;
+                    else
+                        num_value = type_info.octet_length * SIZEOF_CHAR;
                 }
                 else
                 {

diff --git a/driver/platform.h b/driver/platform.h
@@ -50,3 +50,13 @@
 #   define LPCTSTR const char*
 #   define TEXT(value)  value
 #endif
+
+#if defined (UNICODE)
+#   if defined (_win_)
+#       define SIZEOF_CHAR  sizeof(uint_least16_t)
+#   else
+#       define SIZEOF_CHAR  sizeof(char16_t)
+#   endif
+#else
+#   define SIZEOF_CHAR sizeof(char)
+#endif