Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding array to conversion list #2052

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Adding array to conversion list #2052

merged 1 commit into from
Dec 26, 2024

Conversation

mzitnik
Copy link
Contributor

@mzitnik mzitnik commented Dec 26, 2024

Summary

Adding an array to conversion list and fixing testPrimitiveArrays test

Checklist

Delete items not relevant to your PR:

  • Closes issue
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@mzitnik mzitnik marked this pull request as ready for review December 26, 2024 11:32
@mzitnik
Copy link
Contributor Author

mzitnik commented Dec 26, 2024

The are some timeouts that fails other tests. we will address them in another PR

@mzitnik mzitnik merged commit 94ff52b into main Dec 26, 2024
23 of 28 checks passed
@mzitnik mzitnik deleted the fix-array-primitive-test branch December 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentsiLeviav BentsiLeviav BentsiLeviav approved these changes

@Paultagoras Paultagoras Awaiting requested review from Paultagoras

@chernser chernser Awaiting requested review from chernser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzitnik @BentsiLeviav