Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc-v2] Fixed tests #2006

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[jdbc-v2] Fixed tests #2006

merged 1 commit into from
Dec 6, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Dec 6, 2024

Summary

Fixed the test so:

  • only explicit https is valid
  • no ssl property should require - user should specify secure protocol (may be we need to make it by default https)

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from Paultagoras December 6, 2024 19:30
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@chernser chernser merged commit 95c580e into main Dec 6, 2024
58 of 62 checks passed
@chernser chernser deleted the v2_fix_the_test branch December 6, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant