Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DatabaseMetaData.java to handle getPrimaryKeys #2005

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Update DatabaseMetaData.java to handle getPrimaryKeys #2005

merged 7 commits into from
Dec 9, 2024

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Dec 6, 2024 •
edited
Loading

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras self-assigned this Dec 6, 2024
@Paultagoras Paultagoras changed the title Update DatabaseMetaData.java Update DatabaseMetaData.java to handle getPrimaryKeys Dec 6, 2024
mzitnik
mzitnik requested changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide a test?

@Paultagoras
Copy link
Contributor Author

Can we provide a test?

We have a test, I had to modify it with the new logic 🙂

@Paultagoras Paultagoras linked an issue Dec 9, 2024 that may be closed by this pull request
Please implement com.clickhouse.jdbc.ClickHouseDatabaseMetaData.getPrimaryKeys() #1625
Closed
@Paultagoras Paultagoras merged commit b022645 into main Dec 9, 2024
58 of 60 checks passed
@Paultagoras Paultagoras deleted the support-get-primary-keys branch December 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik mzitnik approved these changes

@chernser chernser Awaiting requested review from chernser

Assignees

@Paultagoras Paultagoras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please implement com.clickhouse.jdbc.ClickHouseDatabaseMetaData.getPrimaryKeys()
3 participants
@Paultagoras @mzitnik @chernser