Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Remove dependencies on old projects #1933

Merged
merged 7 commits into from
Nov 21, 2024
Merged

[client-v2] Remove dependencies on old projects #1933

merged 7 commits into from
Nov 21, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 14, 2024 •
edited
Loading

Summary

Client-v2 still uses some classes from old client. This PR fixes this.

Closes: #1899

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser marked this pull request as draft November 14, 2024 22:57
@chernser chernser marked this pull request as ready for review November 20, 2024 07:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
77.0% Coverage on New Code (required ≥ 80%)
12.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@chernser chernser merged commit ce65071 into main Nov 21, 2024
60 of 61 checks passed
@chernser chernser deleted the v2_remove_old_project_dependencies branch November 21, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paultagoras Paultagoras Paultagoras approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] Remove dependencies on old projects
2 participants
@chernser @Paultagoras