Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Persist effect of "SET ROLE" queries. #1569

Merged
merged 23 commits into from
Apr 24, 2024
Merged

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Mar 20, 2024

Summary

Implement setting role per java client. The main goal is to persist set of roles between different HTTP calls because there is no persistent session for a user in that case.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chernser chernser marked this pull request as draft March 20, 2024 14:47
@chernser chernser changed the title WIP Feature set role WIP: Feature set role Mar 20, 2024
@chernser chernser changed the title WIP: Feature set role Feature set role Mar 27, 2024
@chernser chernser marked this pull request as ready for review March 27, 2024 23:17
@mshustov mshustov requested review from mzitnik and slvrtrn March 28, 2024 10:11
@chernser chernser changed the title Feature set role Feature: Persist effect of "SET ROLE" queries. Apr 1, 2024
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<password>123</password>
<quota>default</quota>
<access_management>1</access_management>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete blank line

@slvrtrn
Copy link

slvrtrn commented Apr 19, 2024

@chernser, let's retest with the head version of the ClickHouse docker image and merge it.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
65.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser chernser merged commit 3902d47 into main Apr 24, 2024
58 of 59 checks passed
@chernser chernser deleted the feature-set-role branch May 24, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants