Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration with Spark for array string type #1506

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

phanhuyn
Copy link
Contributor

@phanhuyn phanhuyn commented Dec 22, 2023

Summary

Fix issue in: #1505 by making string type case-insensitive.

Another approach to fix the issue is from Spark's side: apache/spark#44459.

Checklist

  • Changes are verified using a local setup

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2023

CLA assistant check
All committers have signed the CLA.

@mshustov mshustov requested a review from mzitnik January 5, 2024 18:24
@mshustov mshustov added this to the v0.5.1 milestone Jan 7, 2024
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a test failing ClickHouseDataTypeTest.testAlias:15 please adjust the test

@phanhuyn phanhuyn force-pushed the fix-spark-array-string branch from 904f017 to 9a867d7 Compare January 8, 2024 00:24
@phanhuyn
Copy link
Contributor Author

phanhuyn commented Jan 8, 2024

There is a test failing ClickHouseDataTypeTest.testAlias:15 please adjust the test

thanks @mzitnik, I've updated the approach to make String type case-insensitive and remove the "STRING" alias.

@mzitnik mzitnik merged commit 390172c into ClickHouse:main Jan 8, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants