Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buffering issue caused by decompress flag not to work #1500

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Conversation

mzitnik
Copy link
Contributor

@mzitnik mzitnik commented Dec 19, 2023

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mzitnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mzitnik mzitnik changed the title Fix buffering issue caused by decompress not to work Fix buffering issue caused by decompress flag not to work Dec 19, 2023
@mzitnik mzitnik linked an issue Dec 19, 2023 that may be closed by this pull request
Assert.assertFalse(client.ping(getServer(), 3000));
}

// Disable tests for ping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes aren't relevant to the problem, let's merge them separately

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

54.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mzitnik mzitnik merged commit aa3870e into main Dec 21, 2023
52 of 59 checks passed
@mshustov mshustov deleted the fix_decompress branch December 22, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clickhouse-jdbc 0.4.6 decompression issue
3 participants