Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Remove dependencies on old projects #1899

Closed
chernser opened this issue Oct 31, 2024 · 0 comments · Fixed by #1933
Closed

[client-v2] Remove dependencies on old projects #1899

chernser opened this issue Oct 31, 2024 · 0 comments · Fixed by #1933
Assignees
Milestone

Comments

@chernser
Copy link
Contributor

chernser commented Oct 31, 2024

Description

Client-v2 is new implementation of old http client and it has own dependencies. However it still depends on clickhouse-http-client for a few classes. It should be fixed asap because complicates depedencies and may break something.

What should be done:

  • remove any dependencies on clickhouse-http-client project
  • review dependencies on other projects and identify what should be removed, too.

Important: this issue is linked to settings so it also should solve the problem with list of all client options. refer to the comment - main idea to have list of string constants somewhere so it can be passed to the setOption methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant