New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java-client] doc updates for configuration #2942

Merged

gingerwizard merged 2 commits into main from java_client_0.7.2_update

Dec 28, 2024

Contributor

chernser commented Dec 20, 2024

Summary

configuration documentation update
deprecation warning for client-v1

Closes ClickHouse/clickhouse-java#1884
Closes ClickHouse/clickhouse-java#1950
Closes

Checklist

Delete items not relevant to your PR
URL changes should add a redirect to the old URL via https://github.com/ClickHouse/clickhouse-docs/blob/main/docusaurus.config.js
If adding a new integration page, also add an entry to the integrations list here: https://github.com/ClickHouse/clickhouse-docs/blob/main/docs/en/integrations/index.mdx


          doc updates for configuration

0d683f5

chernser requested review from mzitnik, mshustov, laeg and Paultagoras

December 20, 2024 19:36

vercel bot deployed to Preview

December 20, 2024 19:39

View deployment

chernser marked this pull request as ready for review

December 27, 2024 03:14

chernser requested a review from a team as a code owner

December 27, 2024 03:14

gingerwizard reviewed

View reviewed changes

docs/en/integrations/language-clients/java/client-v1.md Outdated Show resolved Hide resolved

gingerwizard reviewed

View reviewed changes

docs/en/integrations/language-clients/java/client-v2.md Outdated Show resolved Hide resolved

gingerwizard reviewed

View reviewed changes

docs/en/integrations/language-clients/java/client-v2.md Show resolved Hide resolved

gingerwizard reviewed

View reviewed changes

docs/en/integrations/language-clients/java/client-v2.md Outdated Show resolved Hide resolved

gingerwizard reviewed

View reviewed changes

docs/en/integrations/language-clients/java/client-v2.md Outdated Show resolved Hide resolved

gingerwizard requested changes

View reviewed changes

Contributor

gingerwizard left a comment

Spelling issues but id like @mshustov to provide final approvals

Contributor Author

chernser commented Dec 27, 2024

@gingerwizard thank you for the review! Will update.


          fixed spelling and other review comments

183acac

chernser requested a review from gingerwizard

December 27, 2024 19:25

vercel bot had a problem deploying to Preview

December 27, 2024 19:27

Failure

mshustov approved these changes

View reviewed changes

gingerwizard merged commit ad42532 into main

3 of 4 checks passed

chernser deleted the java_client_0.7.2_update branch

December 28, 2024 15:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mshustov mshustov approved these changes

mzitnik Awaiting requested review from mzitnik

laeg Awaiting requested review from laeg

Paultagoras Awaiting requested review from Paultagoras

gingerwizard Awaiting requested review from gingerwizard

Labels

None yet