-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable breadcrumbs #2779
base: main
Are you sure you want to change the base?
Clickable breadcrumbs #2779
Conversation
DocsCheck fails:
This is because the former is added in #71846 over at main repo and the latter because May also need to add a redirect for that. |
fe184ca
to
c68b309
Compare
Note to self: add back table of contents import to system-tables/index.md |
@@ -0,0 +1 @@ | |||
export { TableOfContents } from "./table_of_contents"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
"title": "Using a clickhouse-local database", | ||
"slug": "/en/chdb/guides/clickhouse-local" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
Closes #2636. Introduces changes to clean up the navigation of docs together with 71846 over on main repo.
PR will fail due to two missing files which were added in the PR on the main repo
Changes
In many places we show an overview page as a sub-child of the category, such as here:
In my opinion this clutters the sidebar, especially when the overview page has the same name as the category. This PR makes a small change to the
sidebarItemsGenerator
such that any file endingindex.md
will not show as a sub-child of the category. The category itself is then given the link to the overview or index page and becomes clickable:Further more, breadcrumbs often did not link to anywhere such as here, because 'introduction' was a category and not a specific page:
Index files are added (in a separate PR) in some places and categories in the sidebar linked such that breadcrumbs are clickable:
Also addresses 2888, adding landing pages where they are missing.
Checklist