Merge pull request #25 from ClickHouse/fix-tsan-condvar

Fix TSan report around condvar in HostResolver
ClickHouse · Jun 23, 2024 · 6463c9c · 6463c9c
2 parents ac9161f + e55b7df
commit 6463c9c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp b/src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp
@@ -122,7 +122,11 @@ bool GeneralHTTPCredentialsProvider::ShouldCreateGeneralHTTPProvider(const Aws::
                 shouldAllow = !addresses.empty();
                 hostResolved = true;
               }
-              hostResolverCV.notify_one();
+              else
+              {
+                std::unique_lock<std::mutex> lock(hostResolverMutex);
+                hostResolverCV.notify_one();
+              }
             };
           pHostResolver->ResolveHost(authority.c_str(), onHostResolved);
           std::unique_lock<std::mutex> lock(hostResolverMutex);
@@ -259,4 +263,4 @@ void GeneralHTTPCredentialsProvider::RefreshIfExpired()
     }
 
     Reload();
-}
+}