Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Presto #195

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Presto #195

wants to merge 4 commits into from

Conversation

Archy-X
Copy link

@Archy-X Archy-X commented Jun 3, 2024

This PR adds results for Presto. https://prestodb.io/

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2024

CLA assistant check
All committers have signed the CLA.

Co-authored-by: Archy-X <[email protected]>
presto/create.sql Show resolved Hide resolved
presto/create.sql Outdated Show resolved Hide resolved

The benchmarks are based on Presto version `0.287`.

We assume that a Presto cluster is already running. For more information, visit [Getting Started](https://prestodb.io/getting-started/).
Copy link
Member

@alexey-milovidov alexey-milovidov Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add instructions on how to install Presto on an empty machine with Ubuntu on AWS.

These instructions should be in the form of a shell script; see benchmark.sh in other directories.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably not possible to have a single script to set up a cluster since the environment is complicated, what should I do?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a standard setup is important otherwise different setups may not give identical results.

Would be nice if you can do either of the following:

  • You can create an AWS AMI and add that AMI id in the README.
  • You can setup a docker-compose based setup of Presto.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allenshen13 As the other commenters said already, benchmark.sh is supposed to be as automatic as possible. This ensures reproducibility and comparability with other systems.

Looking at https://prestodb.io/docs/current/installation/deploy-docker.html, it seem fairly easy to deploy a single-node Presto cluster. The JVM config file could be stored within /presto and copied to the right place by "benchmarks.h". It would be great to have Presto included, would you like to continue this PR?

presto/README.md Outdated
----------
## Steps

1. Download the parquet file and upload it to an S3 Bucket ex. s3://your-bucket/clickbench-parquet/hits/hits.parquet.
Copy link
Member

@alexey-milovidov alexey-milovidov Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have it,

s3://clickhouse-public-datasets/hits_compatible/hits.parquet

or

s3://clickhouse-public-datasets/hits_compatible/athena_partitioned/hits_{0..99}.parquet

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, made a note of this in the README.

@tinybit tinybit self-assigned this Jul 1, 2024
@rschu1ze
Copy link
Member

@Archy-X Still interested in completing this PR? Otherwise, please close it, thanks.

@alexey-milovidov
Copy link
Member

@rschu1ze, we do want to have Presto and Trino, as well as Starburst Cloud, in ClickBench.

@Archy-X
Copy link
Author

Archy-X commented Nov 12, 2024

I am no longer able to work on this, but @wanglinsong or @xpengahana may be able to provide an update/take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants