Spark patch #139
Open
Spark patch #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nickitat
reviewed
Sep 23, 2023
spark/.gitkeep
Outdated
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
looks like this file could be removed
| StructField("RefererHash", LongType, nullable = false), | ||
| StructField("URLHash", LongType, nullable = false), | ||
| StructField("CLID", IntegerType, nullable = false)) | ||
| ) |
There was a problem hiding this comment.
there is no way to create an index, right?
There was a problem hiding this comment.
Yes, no index support
https://spark.apache.org/docs/1.4.0/api/java/org/apache/spark/sql/types/StructField.html
| val timeElapsed = (end - start) / 1000000 | ||
| println(s"Query $itr | Time: $timeElapsed ms") | ||
| itr += 1 | ||
| }) |
spark/benchmark.sh
Outdated
|
|
||
| # For Spark3.0.1 installation: | ||
| # wget --continue https://downloads.apache.org/spark/spark-3.0.1/spark-3.0.1-bin-hadoop2.7.tgz | ||
| # tar -xzf spark-3.0.1-bin-hadoop2.7.tgz |
spark/benchmark.sh
Outdated
| wget --continue 'https://datasets.clickhouse.com/hits_compatible/hits.tsv.gz' | ||
| #gzip -d hits.tsv.gz | ||
| chmod 777 ~ hits.tsv | ||
| $HADOOP_HOME/bin/hdfs dfs -put hits.tsv / |
There was a problem hiding this comment.
But how do I set this variable?
$ echo $HADOOP_HOME
There was a problem hiding this comment.
I cannot find it:
find spark-3.5.0-bin-hadoop3 -name hdfs
|
Added Spark & HDFS deployment details in benchmark.sh script. Added example of log.txt file from HPC-environment. |
|
The script Should be: |
|
|
Updated Spark&HDFS directories creation |
|
I started editing your script to make it self-sufficient, but after fixing the errors, it does not work.
Then: PS. The current version of the script is: |
|
@alexey-milovidov We assume that there is passless ssh connection defined on localhost (in other words, if we will use Please clarify the next details:
|
I do it in this way: create a fresh VM on AWS and run the commands one by one. |
|
@DoubleMindy, let's continue. |
|
Added full HDFS deployment, on "fresh" VM there is no problem with file putting |
|
Sorry, but the script still does not reproduce. I'm copy-pasting the commands one by one, and getting this: |
|
We need a reproducible script to install Spark. It should run by itself. |
|
@DoubleMindy It would be appreciated if you continue with this, but for now I'll close the PR (for cleanup reasons). |
|
I'm very interested in the results of Spark, but we need at least one person who can install it. If a system cannot be easily installed it is a game over. |
| SELECT TraficSourceID, SearchEngineID, AdvEngineID, CASE WHEN (SearchEngineID = 0 AND AdvEngineID = 0) THEN Referer ELSE '' END AS Src, URL AS Dst, COUNT(*) AS PageViews FROM hits WHERE CounterID = 62 AND EventDate >= '2013-07-01' AND EventDate <= '2013-07-31' AND IsRefresh = 0 GROUP BY TraficSourceID, SearchEngineID, AdvEngineID, Src, Dst ORDER BY PageViews DESC LIMIT 10; | ||
| SELECT URLHash, EventDate, COUNT(*) AS PageViews FROM hits WHERE CounterID = 62 AND EventDate >= '2013-07-01' AND EventDate <= '2013-07-31' AND IsRefresh = 0 AND TraficSourceID IN (-1, 6) AND RefererHash = 3594120000172545465 GROUP BY URLHash, EventDate ORDER BY PageViews DESC LIMIT 10; | ||
| SELECT WindowClientWidth, WindowClientHeight, COUNT(*) AS PageViews FROM hits WHERE CounterID = 62 AND EventDate >= '2013-07-01' AND EventDate <= '2013-07-31' AND IsRefresh = 0 AND DontCountHits = 0 AND URLHash = 2868770270353813622 GROUP BY WindowClientWidth, WindowClientHeight ORDER BY PageViews DESC LIMIT 10; | ||
| SELECT DATE_TRUNC('minute', EventTime) AS M, COUNT(*) AS PageViews FROM hits WHERE CounterID = 62 AND EventDate >= '2013-07-14' AND EventDate <= '2013-07-15' AND IsRefresh = 0 AND DontCountHits = 0 GROUP BY DATE_TRUNC('minute', EventTime) ORDER BY DATE_TRUNC('minute', EventTime) LIMIT 10; |
There was a problem hiding this comment.
Here, the OFFSET clause was removed, which is incorrect.
It should be either LIMIT 1010 to get the closest result or subqueries with ROW_NUMBER.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.