Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm bycolumn #805

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rm bycolumn #805

wants to merge 1 commit into from

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented May 20, 2024

Purpose

closes #736

Results

  • SYPD for partitioned turbulent fluxes run increased from ~2.5 to ~3.7 on CPU (not running long enough for consistent SYPD estimates, but definitely increased)
  • partitioned turbulent fluxes now GPU-compatible
  • results are identical to main

Content: bycolumn removed from

  • experiments/ClimaEarth/components/atmosphere/climaatmos_extra_diags.jl
  • src/FluxCalculator.jl.update_turbulent_fluxes (used for partitioned turbulent fluxes)
    • and extended methods for component models
  • get_field, update_field! methods for component models
  • experiments/ClimaEarth/components/ocean/eisenman_seaice.jl solve_eisenman_model

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/bycolumn branch 2 times, most recently from 25d12a9 to 6f571c3 Compare May 21, 2024 05:41
@juliasloan25 juliasloan25 force-pushed the js/bycolumn branch 6 times, most recently from d0d677e to 3730789 Compare June 25, 2024 01:14
src/FluxCalculator.jl Outdated Show resolved Hide resolved
@juliasloan25 juliasloan25 force-pushed the js/bycolumn branch 2 times, most recently from caf579d to 19a90c5 Compare June 25, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests on GPU - remove Fields.bycolumn
2 participants