Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasotarkistus: add ui data to start date and review days #562

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

NC-jsAhonen
Copy link
Contributor

Add two more info balls to the tasotarkistus section: start date and review days.

@@ -933,6 +933,9 @@ export const LeaseRentDueDatesFieldTitles = {
export const LeaseRentOldDwellingsInHousingCompaniesPriceIndexFieldPaths = {
OLD_DWELLINGS_IN_HOUSING_COMPANIES_PRICE_INDEX_TYPE: 'rents.child.children.old_dwellings_in_housing_companies_price_index_type',
POINT_FIGURES: 'rents.child.children.old_dwellings_in_housing_companies_price_index.point_figures',
// The following two are for the UI data purposes only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a common pattern not to name these UiData ones differently?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For START_DATE, the data is derived from lease.start_date directly, but if I mapped the UI data to that field, the info ball would show the same text as in other places the lease.start_date is used. But I decided to map it to a different path to make it possible to create separate notes for it in the tasotarkistus view

For REVIEW_DAYS, it is not a proper form field with data of its own, but it is derived from the lease start date.

@NC-jsAhonen NC-jsAhonen merged commit d188bd8 into develop Dec 27, 2024
3 checks passed
@NC-jsAhonen NC-jsAhonen deleted the MVJ-617-tasotarkistus-more-info-balls branch December 27, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants