refactor: use enums with graphene #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2024
nikomakela
force-pushed
the
KK-1108-refactor-enum-handling
branch
from
9636eaa to
7973984
Compare
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr399.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is failed for https://kukkuu-pr399.api.dev.hel.ninja 😿💢💥💥 |
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr399.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr399.api.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
force-pushed
the
KK-1108-refactor-enum-handling
branch
from
7973984 to
1d1d413
Compare
|
|
KUKKUU-API branch is deployed to platta: https://kukkuu-pr399.api.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kukkuu-pr399.api.dev.hel.ninja 😆🎉🎉🎉 |
nikomakela
commented
Sep 20, 2024
Comment on lines
+14
to
+29
| 'errors': [ | ||
| { | ||
| 'extensions': { | ||
| 'code': 'GENERAL_ERROR' | ||
| }, | ||
| 'locations': [ | ||
| { | ||
| 'column': 3, | ||
| 'line': 3 | ||
| } | ||
| ], | ||
| 'message': '''value too long for type character varying(16) | ||
| ''', | ||
| 'path': [ | ||
| 'addMessage' | ||
| ] |
There was a problem hiding this comment.
This error needs to be fixed.
Comment on lines
+38
to
+53
| 'errors': [ | ||
| { | ||
| 'extensions': { | ||
| 'code': 'GENERAL_ERROR' | ||
| }, | ||
| 'locations': [ | ||
| { | ||
| 'column': 3, | ||
| 'line': 3 | ||
| } | ||
| ], | ||
| 'message': '''value too long for type character varying(16) | ||
| ''', | ||
| 'path': [ | ||
| 'addMessage' | ||
| ] |
There was a problem hiding this comment.
This error needs to be fixed.
Comment on lines
+66
to
+79
| 'extensions': { | ||
| 'code': 'GENERAL_ERROR' | ||
| }, | ||
| 'locations': [ | ||
| { | ||
| 'column': 7, | ||
| 'line': 22 | ||
| } | ||
| ], | ||
| 'message': "Enum 'EventParticipantsPerInvite' cannot represent value: 'EnumMeta.FAMILY'", | ||
| 'path': [ | ||
| 'addEvent', | ||
| 'event', | ||
| 'participantsPerInvite' |
There was a problem hiding this comment.
This error needs to be fixed
Comment on lines
+1698
to
+1715
| 'errors': [ | ||
| { | ||
| 'extensions': { | ||
| 'code': 'GENERAL_ERROR' | ||
| }, | ||
| 'locations': [ | ||
| { | ||
| 'column': 7, | ||
| 'line': 22 | ||
| } | ||
| ], | ||
| 'message': "Enum 'EventParticipantsPerInvite' cannot represent value: 'EnumMeta.FAMILY'", | ||
| 'path': [ | ||
| 'addEvent', | ||
| 'event', | ||
| 'participantsPerInvite' | ||
| ] | ||
| } |
There was a problem hiding this comment.
This error needs to be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KK-1108.
Use the enums as preferred in django graphene. An alternative for #390. See https://github.com/City-of-Helsinki/kukkuu-admin/pull/277/files for schema changes in Kukkuu Admin UI when the graphql schema is generated from this source base.
PR before rebasing: