Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add extra tags to Sentry and modernize SentryReporterAdapter #531

Merged
merged 1 commit into from
Mar 17, 2023
Merged

feat: Add extra tags to Sentry and modernize SentryReporterAdapter #531

merged 1 commit into from
Mar 17, 2023

Conversation

tcitworld
Copy link
Collaborator

  • Add email to user context
  • instance_url for context (especially useful for cron job issues)
  • instance_name for extra context

ChristophWurst
ChristophWurst approved these changes Mar 16, 2023
View reviewed changes
Copy link
Owner

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instance_url and email make sense

instance_name is a bit strange to me but it won't do any harm

@tcitworld
Copy link
Collaborator Author

CI blocked by #520 and other CI stuff

@ChristophWurst
Copy link
Owner

@tcitworld rebase

@ChristophWurst
Copy link
Owner

#540 should fix CI. The "fix" is not very profound but I'm currently unable to come up with a better solution.

@tcitworld
feat: Add extra tags to Sentry and modernize SentryReporterAdapter
c72df01 
- Add email to user context
- instance_url for context (especially useful for cron job issues)
- instance_name for extra context

Signed-off-by: Thomas Citharel <[email protected]>
auto-merge was automatically disabled March 17, 2023 07:47

Head branch was pushed to by a user without write access

@tcitworld
Copy link
Collaborator Author

Rebased, pending workflow approval

@ChristophWurst
Copy link
Owner

Added you as a collaborator 🙏

@ChristophWurst ChristophWurst merged commit d30b40e into ChristophWurst:master Mar 17, 2023
@tcitworld tcitworld deleted the add-extra-tags branch March 17, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcitworld @ChristophWurst