feat: add tests workflow for deno #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
as-sha256
CI
persistent-merkle-tree
persistent-ts
simpleserialize.com
ssz
labels
nazarhussain
changed the title
nazarhussain
changed the title
nazarhussain
force-pushed
the
nh/deno-unit-tests
branch
from
1d52066
to
dac0775
Compare
twoeths
reviewed
Nov 25, 2024
| @@ -1,4 +1,4 @@ | |||
| import {byteArrayToHashObject, HashObject, hashObjectToByteArray} from "@chainsafe/as-sha256/lib/hashObject"; | |||
| import {byteArrayToHashObject, HashObject, hashObjectToByteArray} from "@chainsafe/as-sha256"; | |||
|
while I see the improvement on the source code, like not to import I guess we need to put this on hold until we have final approach on which javascript runtime that lodestar want to experiment ChainSafe/lodestar#7237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the packages compatible with Deno.
Description
Steps to test or reproduce