feat: added ELU metrics #6820
Closed
feat: added ELU metrics #6820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
wemeetagain
requested changes
Jun 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #6820 +/- ##
============================================
+ Coverage 62.21% 62.70% +0.49%
============================================
Files 571 578 +7
Lines 60017 61410 +1393
Branches 1975 2118 +143
============================================
+ Hits 37338 38510 +1172
- Misses 22636 22862 +226
+ Partials 43 38 -5 |
nflaig
reviewed
Jun 7, 2024
| name: `${key}nodejs_eventloop_active`, | ||
| help: "Histogram of Event Loop active time between two successive calls.", | ||
| registers: [register], | ||
| buckets: [1, intervalMs / 10, intervalMs / 2, intervalMs], |
There was a problem hiding this comment.
all metrics need to be in seconds, including buckets
| }); | ||
|
|
||
| const metricActive = new Histogram({ | ||
| name: `${key}nodejs_eventloop_active`, |
There was a problem hiding this comment.
this is in seconds? sould be reflected in the metric name
Suggested change
| name: `${key}nodejs_eventloop_active`, | |
| name: `${key}nodejs_eventloop_active_seconds`, |
|
|
I think it's not as useful to track this as an average over time or at least I don't see which questions this helps to answer. What we might be interested in is the event loop utilization (ELU) during a certain time frame of the slot, e.g. 1-4, 4-8, 8-12, or even on a per second basis. Should be able to achieve this via labels on metrics + running an interval on a clock timer. This could help us analyze what parts of the slot we are overloaded, and if a change improves the ELU for a specific slot frame or not. |
|
can be further discussed in #7147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add extra metrics related to Event Loop utilization
Description
Relies on node:perf_hooks to track Event Loop utilization metrics: Adds the following
histograms:utilizationakin to CPU utilization, but for ELU; between0and1idlehow long the ELU was idle since last poll (every 5s by default)activehow long the ELU was active since last poll (every 5s by default)Those metrics are tracked on
mainthread and currently monitored worker threads.