To Do list: add & remove #2
Conversation
There was a problem hiding this comment.
Hi @CesarHerr, 👋🏻👋🏻
Great job so far! 🤩💯✅
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No Linters error 💯🤩
- Followed GitHub Flow 💯🤩
- Great job working on the functionality 💯
- Professional README ✅
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
modules/crud.js
Outdated
|
|
||
| add(text) { | ||
| const newTodo = new Todo(text); | ||
| this.list.push(newTodo); | ||
| localStorage.setItem('list', JSON.stringify(this.list)); | ||
| this.displayList(); | ||
| } |
There was a problem hiding this comment.
- Great job working on all the functionality but you still have one thing to change when i see the tasks on localstorage I can't see that it has indexes so whenever the user remove the task the indexes should be updated as required ✅⬇🔥🤩 so if you're deleting the first task index 1 from the list, the index of the next task(2) should set to 1) so kindly implement the indexes here to each task 🔥💯
- I can see just completed and the name of the task
There was a problem hiding this comment.
Hi @CesarHerr 👋,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- No Linters error 💯🤩
- Followed GitHub Flow 💯🤩
- Great job working on the functionality 💯
- Professional README ✅
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Davidosky007 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
modules/crud.js
Outdated
|
|
||
| add(text) { | ||
| const newTodo = new Todo(text); | ||
| newTodo.index = this.list.length; |
There was a problem hiding this comment.
- As the previous CR stated your index if you're adding a 5th task to the list, the index of that task should equal 5 for example first todo == index 1, fourth todo == index 4, kindly fix this same thing also should be done when deleting if you're deleting the first task index 1 from the list, the index of the next task(2) should set to 1
There was a problem hiding this comment.
Hi @CesarHerr,
Status: Approved ✅
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Good Highlights✔️
- Requested changes have been implemented
- Application works as expected
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
length. ✔️