Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fast/Fancy for graphics, clouds, weather, leaves #2291

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Madis0
Copy link
Contributor

@Madis0 Madis0 commented Jan 30, 2024

  • Adds new separate "fast" and "fancy" strings for leaves and weather, for languages like Russian where reusing the Graphics ones would sound incorrect.
  • Fixes graphics options using clouds' fast/fancy, and clouds options using graphics' fast/fancy

return (this == FANCY) || (this == DEFAULT && (graphicsMode == GraphicsMode.FANCY || graphicsMode == GraphicsMode.FABULOUS));
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully sure if these enums are still wanted or if I should just do a Text[] like it is in clouds.

@Madis0 Madis0 changed the title Separate Fast/Fancy for clouds, weather, leaves Fix Fast/Fancy for clouds, weather, leaves Jan 30, 2024
@Madis0 Madis0 changed the title Fix Fast/Fancy for clouds, weather, leaves Fix Fast/Fancy for graphics, clouds, weather, leaves Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant