Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lineTo to do nothing instead of raising error when 0 length #1606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

endikallanomatxin
Copy link

@endikallanomatxin endikallanomatxin commented Jun 18, 2024

Before the change it raised an error when startPoint and endPoint were equal

@endikallanomatxin endikallanomatxin changed the title Fix lineTo to do nothing instead of raising error when startPoint and… Fix lineTo to do nothing instead of raising error when 0 length Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.83%. Comparing base (33f72d2) to head (e3d6907).

Files Patch % Lines
cadquery/cq.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
- Coverage   94.86%   94.83%   -0.04%     
==========================================
  Files          28       28              
  Lines        6231     6233       +2     
  Branches     1264     1265       +1     
==========================================
  Hits         5911     5911              
- Misses        193      194       +1     
- Partials      127      128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant