Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop various UI issues #2522

Merged
merged 15 commits into from
Sep 12, 2024
Merged

Develop various UI issues #2522

merged 15 commits into from
Sep 12, 2024

Conversation

SolidProgramming
Copy link

@SolidProgramming SolidProgramming commented Sep 6, 2024 •
edited
Loading

closes #2524
closes #2523
closes #2513
closes #2181

@tpurschke tpurschke changed the title Develop Develop various UI issues Sep 6, 2024
@SolidProgramming SolidProgramming marked this pull request as ready for review September 6, 2024 19:08
@tpurschke tpurschke added this to the next consolidation issues milestone Sep 9, 2024
@SolidProgramming SolidProgramming marked this pull request as draft September 9, 2024 06:47
@SolidProgramming SolidProgramming marked this pull request as ready for review September 9, 2024 13:57
tpurschke
tpurschke reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@tpurschke tpurschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good do you think that we could also accept html formatting here?
using something like System.Web.HttpUtility.HtmlDecode(rawText)

tpurschke
tpurschke approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@tpurschke tpurschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great first PR

@tpurschke tpurschke merged commit b0e5142 into CactuseSecurity:develop Sep 12, 2024
1 check passed
@SolidProgramming SolidProgramming deleted the develop branch September 12, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpurschke tpurschke tpurschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next consolidation issues
Development

Successfully merging this pull request may close these issues.
2 participants
@SolidProgramming @tpurschke