-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux-cachyos: Move AutoFDO Option to default kernel #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jung <[email protected]>
Signed-off-by: Peter Jung <[email protected]>
ventureoo
reviewed
Dec 1, 2024
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
ventureoo
force-pushed
the
use-autofdo
branch
from
December 1, 2024 17:54
88303b6
to
089f29c
Compare
sirlucjan
approved these changes
Dec 2, 2024
1Naim
reviewed
Dec 2, 2024
1Naim
reviewed
Dec 2, 2024
1Naim
reviewed
Dec 2, 2024
1Naim
reviewed
Dec 2, 2024
1Naim
reviewed
Dec 2, 2024
Signed-off-by: Vasiliy Stelmachenok <[email protected]>
1Naim
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lets merge for 6.12.2 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last week's testing showed that the AutoFDO Integration did not provide any issues.
Lets move it to the default Kernel now, to provide this performance benefit OOB.
Until the LLVM 19 push into the archlinux repository we will use cachyos-benchmarker to profile the kernel.
In the future, we can think about a general workflow to gather more profiles and merge these.
Propellor will be also available with LLVM 19, but for this I would like to do again a testing kernel first.
AutoFDO and Propellor has been merged into the upstream kernel, which makes it even more confident to use this feature OOB.
Closes: #325