Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fact Decorator Rough Sketch #381

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris-pardy
Copy link
Collaborator

@CacheControl this is very much just a rough sketch of what a "FactDecorator" that matched the "Operator Decorator" would look like.

The idea here is to add support for a way to declaratively manipulate fact values without needed to manually add new facts.
I've created defaults for what I think the most common use cases are:

keyOf / valueOf - these work on the methods defined on Map but also use the Object.keys / Object.values methods to enumerate the keys and values of other objects. For instance you could now do:

const fact = new Fact("test", { editable: true });

const condition = {
     fact: "keysOf:test",
     operator: "contains",
     value: "editable"
} 

I've also added sizeOf which works on strings so:

const condition = {
     fact: "sizeOf:password",
    operator: "greaterThanInclusive",
    value: 12
}

Finally I wanted to showcase how we could use this to potentially move the handling of JSON Path properties out of the Almanac and into something that would let us move the JSONPathPlus dependency to a peer-dependency which would make it much easier to tackle breaking changes.

This would introduce the concept of a FactDecorator to match
the idea of a operator decorator. Fact Decorators could be used to do things like  getting keysOf, valuesOf, or sizeOf facts.
Additionally in order to Remove JSONPathPlus as such a dependency we could use the fact decorator pattern, even if we wanted to ship our own decorator that depended on JSON path we could move it to a peer dependency.
@CacheControl
Copy link
Owner

@chris-pardy the approach makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants